New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only set mask attribute if the corresponding mask exists #112

Merged

vinothpandian merged 2 commits into vinothpandian:main from playgroundai:main

Jan 31, 2023

+1 −1

Contributor

nhnt11 commented Jan 29, 2023

Without this PR it's possible to have path groups that link to masks that don't exist because eraserPaths might be empty.

The linking of non-existent paths is what was breaking things on Firefox for me. With this PR, things seem to work great on Firefox.

nhnt11 added 2 commits

January 29, 2023 11:37


          Don't set mask attr unless eraser path exists

6965a06


          fix string

3b9cdd7

Contributor Author

nhnt11 commented Jan 29, 2023

Fixes #54

vinothpandian merged commit 7a5f481 into vinothpandian:main

MrMarble mentioned this pull request

Canvas doesn't work properly on Firefox / Android replicate/scribble-diffusion#17

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet